| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Date: | 2010-12-27 15:54:16 |
| Message-ID: | 1293465256.11075.1.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On sön, 2010-12-26 at 12:31 -0500, Tom Lane wrote:
> We did clean up C++ keyword uses in the header files in 9.0, but your
> report shows it's already gotten broken again. I'm disinclined to fix
> it unless someone steps up to create an automated test that will get
> run reasonably often. We had that discussion when the patch to rename
> keyword-named fields was proposed, and nothing got done, and the
> current state of affairs is the entirely predictable result.
src/tools/pginclude/cpluspluscheck
What's missing is to automate this, but it's unclear in what context,
and perhaps also to what extend this should be a hard requirement.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-12-27 16:12:54 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Previous Message | Tom Lane | 2010-12-27 15:20:32 | Re: Postgresql 9 connection problem |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-12-27 15:55:11 | Re: Streaming replication as a separate permissions |
| Previous Message | Simon Riggs | 2010-12-27 15:52:47 | Re: Reduce lock levels for ADD and DROP COLUMN |