From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Comment typo in nodeWindowAgg.c |
Date: | 2010-12-21 21:17:49 |
Message-ID: | 1292966269.8045.11.camel@jansson |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Found a couple of small typos in the comments of nodeWindowAgg.c when
they refer to functions in nodeAgg.c. The pluralities of the function
names (initialize_aggregates and advance_aggregates) are wrong. The
reference to "finalize_aggregate" is correct though.
diff --git a/src/backend/executor/nodeWindowAgg.c
b/src/backend/executor/nodeWindowAgg.c
index c3efe12..51f98c1 100644
*** a/src/backend/executor/nodeWindowAgg.c
--- b/src/backend/executor/nodeWindowAgg.c
*************** static bool window_gettupleslot(WindowOb
*** 181,187 ****
/*
* initialize_windowaggregate
! * parallel to initialize_aggregate in nodeAgg.c
*/
static void
initialize_windowaggregate(WindowAggState *winstate,
--- 181,187 ----
/*
* initialize_windowaggregate
! * parallel to initialize_aggregates in nodeAgg.c
*/
static void
initialize_windowaggregate(WindowAggState *winstate,
*************** initialize_windowaggregate(WindowAggStat
*** 207,213 ****
/*
* advance_windowaggregate
! * parallel to advance_aggregate in nodeAgg.c
*/
static void
advance_windowaggregate(WindowAggState *winstate,
--- 207,213 ----
/*
* advance_windowaggregate
! * parallel to advance_aggregates in nodeAgg.c
*/
static void
advance_windowaggregate(WindowAggState *winstate,
Regards,
Andreas Karlsson
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2010-12-21 21:20:00 | Re: wCTE behaviour |
Previous Message | Peter Eisentraut | 2010-12-21 21:14:31 | Re: wCTE behaviour |