Re: GiST seems to drop left-branch leaf tuples

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Peter Tanski <ptanski(at)raditaz(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GiST seems to drop left-branch leaf tuples
Date: 2010-11-23 15:22:59
Message-ID: 1290525717-sup-8003@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Peter Tanski's message of mar nov 23 12:00:52 -0300 2010:

> There are checks inside the Picksplit() function for the number of entries:
>
> OffsetNumber maxoff = entryvec->n - 1;
> int n_entries, j;
> n_entries = Max(maxoff, 1) - 1;
>
> j = 0;
> for (i = FirstOffsetNumber; i < maxoff; i = OffsetNumberNext(i)) {
> FPrint* v = deserialize_fprint(entv[i].key);

Isn't this off by one? Offset numbers are 1-based, so the maxoff
computation is wrong.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-11-23 15:51:01 Re: visibility map
Previous Message Peter Tanski 2010-11-23 15:00:52 Re: GiST seems to drop left-branch leaf tuples