Re: Initial review of xslt with no limits patch

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Mike Fowler <mike(at)mlfowler(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Initial review of xslt with no limits patch
Date: 2010-08-06 20:45:58
Message-ID: 1281127558.2563.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2010-08-06 at 13:01 -0400, Tom Lane wrote:
> 2. I'm not sure whether we ought to auto-single-quote the values.
> If we don't, how hard is it for users to properly quote nonconstant
> parameter values? (Will quote_literal work, or are the quoting rules
> different for libxslt?) If we do, are we giving up functionality
> someone cares about?

Not every parameter is a string.

Compare xsltproc:

--param PARAMNAME PARAMVALUE
Pass a parameter of name PARAMNAME and value PARAMVALUE to the
stylesheet. You may pass multiple name/value pairs up to a
maximum of 32. If the value being passed is a string, you can use
--stringparam instead, to avoid additional quote characters
that appear in string expressions. Note: the XPath expression
must be UTF-8 encoded.

--stringparam PARAMNAME PARAMVALUE
Pass a parameter of name PARAMNAME and value PARAMVALUE where
PARAMVALUE is a string rather than a node identifier. Note:
The string must be UTF-8 encoded.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-08-06 20:48:58 Re: Initial review of xslt with no limits patch
Previous Message David E. Wheeler 2010-08-06 20:45:46 Update hstore % Doc