Re: need more ALTER TABLE guards for typed tables

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: need more ALTER TABLE guards for typed tables
Date: 2010-07-21 19:48:36
Message-ID: 1279741672-sup-9800@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010:
> After some investigation I figured that I need to add two more checks
> into the ALTER TABLE code to prevent certain types of direct changes to
> typed tables (see attached patch).
>
> But it's not clear to me whether such checks should go into the "Prep"
> or the "Exec" phases. Prep seems more plausible to me, but some
> commands such as DropColumn don't have a Prep handler. A clarification
> would be helpful.

I think if there's no Prep phase, you should add it. I don't think it
makes sense to have this kind of check in Exec.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-07-21 19:59:43 Re: documentation for committing with git
Previous Message David Christensen 2010-07-21 19:44:11 Re: documentation for committing with git