Re: Allow wal_keep_segments to keep all segments

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow wal_keep_segments to keep all segments
Date: 2010-06-03 19:16:08
Message-ID: 1275592396-sup-7506@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Bruce Momjian's message of jue jun 03 08:36:28 -0400 2010:

> Using this only temporarily is mentioned in the doc patch. Do I need
> more?

Yeah, it's far too easy to miss. Besides, I think the wording you used
is ambiguous -- it can be read as "the server will temporarily keep all
segments if you set it to -1", which is not the same thing at all. If
you can't add a 20-point-font red blinking warning with a pink dancing
elephant in a tutu, maybe it's best to not offer the dangerous setting
in the first place.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-06-03 19:35:35 Re: Allow wal_keep_segments to keep all segments
Previous Message Dan Colish 2010-06-03 19:02:01 SET CONSTRAINTS todo