Re: Win64 warnings about size_t

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Win64 warnings about size_t
Date: 2010-01-01 19:12:43
Message-ID: 1262373163.29407.4.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2010-01-01 at 20:01 +0100, Magnus Hagander wrote:
> .\src\backend\utils\mmgr\aset.c(701): warning C4334: '<<' : result
> of 32-bit shift implicitly converted to 64 bits (was 64-bit shift
> intended?)
> .\src\backend\utils\mmgr\aset.c(705): warning C4334: '<<' : result
> of 32-bit shift implicitly converted to 64 bits (was 64-bit shift
> intended?)
>
> Perhaps we need some casting there?

This shouldn't be a problem for the same reason that casting size_t to
int is not a problem in the PostgreSQL backend code, but perhaps writing
1L << ... would fix it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-01-01 19:25:21 win32 socket definition
Previous Message Peter Eisentraut 2010-01-01 19:03:28 Re: PATCH: Add hstore_to_json()