Re: updateMinRecoveryPoint bug?

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: updateMinRecoveryPoint bug?
Date: 2009-12-28 16:14:12
Message-ID: 1262016852.18116.4384.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2009-12-28 at 14:40 +0200, Heikki Linnakangas wrote:
> Fujii Masao wrote:

> > How about always resetting ControlFile->minRecoveryPoint to {0, 0} at the
> > beginning of a crash recovery, to fix the bug?
>
> Yeah, that would work. I think it would be better to clear it in
> CreateCheckPoint(), though, when we set the pointer to the new
> checkpoint. That includes the shutdown checkpoint created at the end of
> archive recovery. minRecoveryPoint should never be set during normal
> operation, after all.

Sounds better.

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-28 16:20:19 Re: [PATCH] Provide rowcount for utility SELECTs
Previous Message Peter Eisentraut 2009-12-28 16:14:04 Re: [PATCH] Provide rowcount for utility SELECTs