| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot Standby, release candidate? |
| Date: | 2009-12-14 11:11:46 |
| Message-ID: | 1260789106.1955.584.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2009-12-14 at 11:09 +0100, Magnus Hagander wrote:
> On Mon, Dec 14, 2009 at 10:54, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> > * Please remove any spurious whitespace. "git diff --color" makes them
> > stand out like a sore thumb, in red. (pgindent will fix them but always
> > better to fix them before committing, IMO).
>
> +1 in general, not particularly for this patch (haven't checked that
> in this patch).
>
> Actually, how about we add that to the page at
> http://wiki.postgresql.org/wiki/Submitting_a_Patch?
If we can define "spurious whitespace" it would help decide whether
there is any action to take, and when.
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2009-12-14 11:15:47 | Re: Hot Standby, release candidate? |
| Previous Message | Simon Riggs | 2009-12-14 11:07:44 | Re: Hot Standby, deferred conflict resolution for cleanup records (v2) |