| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot standby, misc issues |
| Date: | 2009-12-05 17:24:55 |
| Message-ID: | 1260033895.13774.41472.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2009-12-04 at 10:23 +0200, Heikki Linnakangas wrote:
>
> > @Heikki: Why is error checking in KnownAssignedXidsRemove() #ifdef'd
> out??
>
> It's explained in the comment:
> /* XXX: This can still happen: If a transaction with a subtransaction
> * that haven't been reported yet aborts, and no WAL records have been
> * written using the subxid, the abort record will contain that subxid
> * and we haven't seen it before.
> */
Just realised that this occurs again because the call to
RecordKnownAssignedTransactionIds() was removed from
xact_commit_abort().
I'm guessing you didn't like the call in that place for some reason,
since I smile while I remember it has been removed twice(!) even though
I put "do not remove" comments on it to describe this corner case.
Not going to put it back a third time.
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2009-12-05 17:49:24 | Reading recovery.conf earlier |
| Previous Message | Tom Lane | 2009-12-05 17:17:27 | Re: First feature patch for plperl - draft [PATCH] |