Re: CREATE RULE "_RETURN" and toast tables

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> due to no respective element being in in table_toast_list nothing is
> vacuumed and you cannot escape the situation. Not very nice. I wonder if
> we should do something about it even due 8.3 is formally out of support,

Out of support is out of support. We're certainly not going to update
8.3 to fix corner cases that escaped notice for the five years it was in
support. (And it's not true that you can't get out of it --- if nothing
else, you could manually update the toast table's relfrozenxid value.)

> The current behaviour doesn't seem to be a terribly good idea. I propose
> to drop the toast table and reset the relfrozenxid in DefineQueryRewrite
> in the RelisBecomingView case.

Yeah, probably worth doing. At the time we thought that that code path
was just a short-term legacy thing for loading ancient pg_dump files.
However, given that even modern pg_dumps will use this syntax if
necessary to break circular dependencies for views, we're probably never
going to be rid of it completely.

regards, tom lane