| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Broken code in pquery.c |
| Date: | 2004-03-18 21:28:36 |
| Message-ID: | 12513.1079645316@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The if() statement at line 418 in pquery.c seems a bit bereft of
controlled statement; looks like a broken log_executor_stats patch.
if (portal->strategy != PORTAL_MULTI_QUERY)
{
ereport(DEBUG3,
(errmsg_internal("PortalRun")));
/* PORTAL_MULTI_QUERY logs its own stats per query */
if (log_executor_stats)
ResetUsage();
}
---> if (log_executor_stats && portal->strategy != PORTAL_MULTI_QUERY)
/*
* Check for improper portal use, and mark portal active.
*/
if (portal->portalDone)
ereport(ERROR,
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("portal \"%s\" cannot be run anymore", portal->name)));
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2004-03-18 21:39:07 | Authentication drop-down? |
| Previous Message | Larry Rosenman | 2004-03-18 21:24:43 | UnixWare/CVS Tip/initdb.c needs to use threads flags... |