Re: 8.1-compatible xlogdump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 8.1-compatible xlogdump
Date: 2005-11-02 04:24:13
Message-ID: 1247.1130905453@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Jonah H. Harris wrote:
>> Does anyone have a copy of xlogdump updated for 8.1? If so, please send me a
>> copy. Otherwise I'll update it and forward the diffs.

> We should definitely consider completing it and including it in contrib.

There is already code in the main backend to convert all the xlog record
types into text. We should think of some way to reuse that code, rather
than maintaining identical functionality elsewhere.

Mind you, the backend code pretty much sucks from a robustness point of
view (unchecked string buffer use) so rewriting it along the way isn't
a bad idea. I'm just saying let's think about how to have one copy not
two.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-02 04:45:12 Re: slru.c race condition (was Re: TRAP: FailedAssertion("!((itemid)->lp_flags
Previous Message Andrew Dunstan 2005-11-02 04:21:39 Re: pg_restore [archiver] file offset in dump file is too