Re: IMPORT FOREIGN SCHEMA return create foreign table commands are those further filtered in LIMIT and EXCEPT cases?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Paragon Corporation" <lr(at)pcorp(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: IMPORT FOREIGN SCHEMA return create foreign table commands are those further filtered in LIMIT and EXCEPT cases?
Date: 2015-12-31 22:48:25
Message-ID: 12427.1451602105@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Paragon Corporation" <lr(at)pcorp(dot)us> writes:
>> Yes. The FDW author is not expected to implement those clauses; where do
>> you see documentation saying otherwise?

> I didn't. I was copying the postgres_fdw and noticed it implemented them
> directly.

Ah. I believe that's mostly just an efficiency hack (and a fairly trivial
one too, at least in postgres_fdw's case). I suppose there might be an
argument that if we don't exclude tables at this stage, we could get a
parse-time failure from features not supported on the local server, which
would be unexpected if the user had told us to skip such tables. But that
seems a bit implausible.

I'll go add a comment about this though, to clarify matters for the
next person.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-12-31 23:08:34 Re: PATCH: Extending the HyperLogLog API a bit
Previous Message Tom Lane 2015-12-31 22:30:33 Re: New ALTER OPERATOR command fails to update dependencies