Re: Patch to fix search_path defencies with pg_bench

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: jd(at)commandprompt(dot)com
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>, Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch to fix search_path defencies with pg_bench
Date: 2009-05-07 17:07:48
Message-ID: 1241716068.6109.291.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Thu, 2009-05-07 at 09:53 -0700, Joshua D. Drake wrote:
> On Thu, 2009-05-07 at 12:47 -0400, Tom Lane wrote:
>
> > Well, pgbench has been coded this way since forever and we've only seen
> > this one report of trouble. Still, I can't object very hard to renaming
> > the tables to pgbench_accounts etc --- it's a trivial change and the
> > only thing it could break is custom pgbench scenarios that rely on the
> > default scenario's tables, which there are probably not many of.
> >
> > So do we have consensus on dropping the "SET search_path" and renaming
> > the tables?
>
> +1 (I hate prefixed table names but I get the idea)

+1, sorry JD.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-05-07 17:08:16 Re: Patch to fix search_path defencies with pg_bench
Previous Message Aidan Van Dyk 2009-05-07 17:05:35 Re: Patch to fix search_path defencies with pg_bench