Re: pg_get_triggerdef in pg_dump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Pflug <Andreas(dot)Pflug(at)web(dot)de>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_get_triggerdef in pg_dump
Date: 2003-06-17 14:09:18
Message-ID: 12411.1055858958@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andreas Pflug <Andreas(dot)Pflug(at)web(dot)de> writes:
> Difference from Christopher's solution is that mine utilizes completely
> separatated (copied) code, so ruleutils code is still unchanged. This
> was a concession to Tom who claimed concerns about pg_dump not being
> able to reproduce things correctly if there was *any* error in it.

I recall objecting to someone who wanted to remove "unnecessary"
parentheses, but I can't see any risk in inserting unnecessary
whitespace.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-06-17 14:11:41 Re: [HACKERS] CVS -Tip compile issue -- FreeBSD 4.8
Previous Message Peter Eisentraut 2003-06-17 12:35:27 Re: [HACKERS] CVS -Tip compile issue -- FreeBSD 4.8