Re: compile warning in CVS HEAD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: compile warning in CVS HEAD
Date: 2004-03-18 21:13:14
Message-ID: 12394.1079644394@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> *sigh*

> my local (linux) man for gettimeofday says this:

> struct timeval {
> time_t tv_sec; /* seconds */
> suseconds_t tv_usec; /* microseconds */
> };

Yeah, but mine (HPUX) says that tv_sec is "unsigned long". I suspect
that on Darwin the types disagree as to signedness.

> We could do what you say, or could we just cast it?

If they really were different types (as in different widths) then
casting the pointer would be a highly Wrong Thing. I think copying
to a local is safer, even if it does waste a cycle or two.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Larry Rosenman 2004-03-18 21:24:43 UnixWare/CVS Tip/initdb.c needs to use threads flags...
Previous Message Kurt Roeckx 2004-03-18 21:09:51 Re: [HACKERS] fsync method checking

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2004-03-18 21:24:43 UnixWare/CVS Tip/initdb.c needs to use threads flags...
Previous Message Andrew Dunstan 2004-03-18 20:43:47 Re: compile warning in CVS HEAD