Re: SnapshotResetXmin

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SnapshotResetXmin
Date: 2009-01-16 17:36:26
Message-ID: 1232127386.31669.63.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Fri, 2009-01-16 at 12:13 -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Simon Riggs wrote:
> >> SnapshotResetXmin is called 3 times after each statement in
> >> ReadCommitted mode.
>
> > Maybe we could check whether TransState is not TRANS_INPROGRESS and skip
> > it in those cases ...?
>
> Surely this would take longer than the function itself does. What's
> the point of worrying at all?

I thought it *might* be indicative of over zealous coding, thats all.

Better a false-positive than to miss a possible issue.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2009-01-16 17:37:01 Re: FWD: Re: Updated backslash consistency patch
Previous Message Tom Lane 2009-01-16 17:35:55 Re: FWD: Re: Updated backslash consistency patch