From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add API functions to libpq to interrogate SSL related stuff. |
Date: | 2015-02-04 00:23:23 |
Message-ID: | 12315.1423009403@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Add API functions to libpq to interrogate SSL related stuff.
This patch is one large brick shy of a load: it creates exported libpq
functions but fails to ensure they always exist. That's why jacana is
unhappy; though TBH I'm astonished that any non-ssl-enabled builds
are passing. Apparently missing library functions are less of a hard
error on Linux than they ought to be.
I think probably the exported functions need to be defined in fe-exec.c
or fe-connect.c, with bodies along the lines of
#ifdef USE_OPENSSL
call OpenSSL-specific function
#else
return NULL
#endif
(or whatever's appropriate when no SSL support). We do want these
functions to exist even in non-SSL-enabled builds.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-02-04 07:13:27 | pgsql: Add dummy PQsslAttributes function for non-SSL builds. |
Previous Message | pgsql | 2015-02-04 00:07:20 | pgsql: Tag refs/tags/REL9_0_19 was created |
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2015-02-04 00:40:03 | Re: Fwd: [GENERAL] 4B row limit for CLOB tables |
Previous Message | Noah Yetter | 2015-02-03 23:26:01 | GRANT USAGE on FOREIGN SERVER exposes passwords |