Re: pgsql: Preserve intermediate .c files in coverage mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Preserve intermediate .c files in coverage mode
Date: 2012-10-28 15:10:34
Message-ID: 12296.1351437034@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Preserve intermediate .c files in coverage mode
>
> The introduction of the .y -> .c pattern rule causes some .c files such
> as bootparse.c to be considered intermediate files in the .y -> .c -> .o
> rule chain, which make would automatically delete. But in coverage
> mode, the processing tools such as genhtml need those files, so mark
> them as "precious" so that make preserves them.

[ blink... ] I'd vote for making them precious all the time. No such
behavioral change was discussed or agreed to, and I'm concerned about
possible side effects, for instance losing files that you don't have the
tools to rebuild when working from a distributed tarball.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-10-30 21:11:14 Re: [COMMITTERS] pgsql: Preserve intermediate .c files in coverage mode
Previous Message Peter Eisentraut 2012-10-28 14:42:25 pgsql: Preserve intermediate .c files in coverage mode

Browse pgsql-hackers by date

  From Date Subject
Next Message David Lee 2012-10-28 15:22:08 Re: Creating indexes in the background
Previous Message David Johnston 2012-10-28 14:48:24 Re: Creating indexes in the background