| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| Date: | 2016-04-08 18:44:14 |
| Message-ID: | 12282.1460141054@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Fri, Apr 8, 2016 at 11:31 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> +1. I wonder if this should be reverted entirely.
> I really wish I could have done more to help with this, but I didn't
> do enough soon enough. Regrettably, I think that the patch just isn't
> ready. For example, the way that expression indexes just aren't
> handled is a cause for concern, as is the general way in which high
> keys are modified during index builds. Interactions with logical
> decoding are also a concern; there could be significant issues there,
> but that analysis just didn't happen. I had significant
> misunderstandings about the patch as recently as this week.
> This should be reverted.
Given those concerns, this *clearly* was not ready to commit.
Please revert, Teodor.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2016-04-08 18:49:18 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| Previous Message | Peter Geoghegan | 2016-04-08 18:40:01 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-08 18:47:35 | Re: Show dropped users' backends in pg_stat_activity |
| Previous Message | Peter Geoghegan | 2016-04-08 18:43:25 | Re: Fix for OpenSSL error queue bug |