Re: [PATCHES] Infrastructure changes for recovery (v8)

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Infrastructure changes for recovery (v8)
Date: 2008-11-17 15:33:13
Message-ID: 1226935993.3790.12.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:

> > +
> > + /*
> > + * Load the flat authorization file into
> postmaster's ca
> > + * startup process won't have recomputed
> this from the d
> > + * yet, so it may change following recovery.
> > + */
> > + load_role();
>
> Is there a race condition here too, if the startup process is writing
> the auth file at the same time? I guess we'd have the same problem
> with flat files in general, so maybe there's something else that
> mitigates the problem?

The flat file is not race condition proof. When the file is read it is
just a guide and the real data is re-accessed from catalog. So the
problem you see does exist, but is handled elsewhere - not in this
patch.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aidan Van Dyk 2008-11-17 15:36:53 Re: Block-level CRC checks
Previous Message Simon Riggs 2008-11-17 15:31:16 Re: [PATCHES] Infrastructure changes for recovery (v8)

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-11-17 15:39:42 Re: [PATCHES] Infrastructure changes for recovery (v8)
Previous Message Simon Riggs 2008-11-17 15:31:16 Re: [PATCHES] Infrastructure changes for recovery (v8)