Re: make dist does not include man.tar.gz and postgres.tar.gz

From: Devrim GÜNDÜZ <devrim(at)gunduz(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
Subject: Re: make dist does not include man.tar.gz and postgres.tar.gz
Date: 2008-09-03 04:07:50
Message-ID: 1220414870.8857.238.camel@laptop.gunduz.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, 2008-09-02 at 17:03 -0400, Tom Lane wrote:
> I think you need "make distprep" first.

Still, we have problems here. I first created man.tar.gz,
postgres.tar.gz and ran gmake INSTALL HISTORY under doc/src/sgml and
moved them to top level directory. However, I am getting the following
error regardless I ran distprep or not:

$ make VERSION=8.4devel dist
rm -rf postgresql-8.4devel* =install=
for x in `cd . && find . -name CVS -prune -o -print`; do \
file=`expr X$x : 'X\./\(.*\)'`; \
if test -d "./$file" ; then \
mkdir "postgresql-8.4devel/$file" && chmod 777
"postgresql-8.4devel/$file"; \
else \
ln "./$file" "postgresql-8.4devel/$file" >/dev/null 2>&1 \
|| cp "./$file" "postgresql-8.4devel/$file"; \
fi || exit; \
done
cp: cannot stat `./doc/src/sgml/CREATE': No such file or directory
make: *** [distdir] Error 1

The problem is (as Alvaro stated me on Jabber), the space between CREATE
and AGGREGATE (there are a bunch of them actually). Checked GNUMakefile
and saw this in distdir target:

cp "$(top_srcdir)/$$file" "$(distdir)/$$file";

I thought quotes would help us here, but apparently it does not.

However, when I run ./configure and make dist, and then extract the
tarball, generate man.tar.gz with postgres.tar.gz, add these to the
previous tarball and rewrap it, it works. But I "want to" assume that it
is not the way that PostgreSQL tarballs are created.

> I've never seen Marc's actual build script, however.

I have zero idea why these scripts are not included in CVS...

Regards,
--
Devrim GÜNDÜZ, RHCE
devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
http://www.gunduz.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-09-03 05:47:13 Re: Window functions patch v04 for the September commit fest
Previous Message Tom Lane 2008-09-03 03:53:27 Re: [gsmith@gregsmith.com: Re: [patch] GUC source file and line number]