Re: Explain XML patch v2

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Tom Raney <raneyt(at)cecs(dot)pdx(dot)edu>, pgsql-patches(at)postgresql(dot)org, Gregory Stark <stark(at)enterprisedb(dot)com>
Subject: Re: Explain XML patch v2
Date: 2008-07-05 09:41:18
Message-ID: 1215250878.4051.268.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On Fri, 2008-07-04 at 19:38 +0100, Dave Page wrote:
> On Fri, Jul 4, 2008 at 5:20 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >
> > * If the patch was implemented as an ExplainOneQuery_hook we would be
> > able to use this with 8.3 also, which might be interesting. So there's
> > no real need for this to be a patch on core.
>
> Would that mean that instead of being an optional format that pgAdmin
> could request with appropriate grammar, it would be something that was
> only available if the plugin was loaded, and would replace regular
> EXPLAIN output? If so, that would be extremely inconvenient, and next
> to useless for general purpose utilities.

It can be optional since plugins can add parameters also.

It wouldn't take long to make up a plugin for 8.3 once this patch has
been committed to core for 8.4, so if you're saying you'd definitely
like it in core then I'm OK with that.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-07-05 09:50:35 Re: Explain XML patch v2
Previous Message Magnus Hagander 2008-07-05 09:34:18 Re: pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-07-05 09:50:35 Re: Explain XML patch v2
Previous Message Hans-Juergen Schoenig 2008-07-05 08:43:57 Re: WITH RECURSIVE updated to CVS TIP