Re: pgsql: Buffering GiST index build algorithm.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Buffering GiST index build algorithm.
Date: 2011-09-08 20:44:47
Message-ID: 12115.1315514687@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Maybe we need to include math.h. And while we're about it, should the
>> result of round() be cast to an int, since that's what the function
>> returns?

> Or use rint(), which we certainly have.

Yeah, this broke the build on my old HPUX box too. I committed a quick
fix using rint(), but on reflection I wonder if it shouldn't be ceil().

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-09-08 21:14:51 pgsql: Stamp 9.1.0.
Previous Message Tom Lane 2011-09-08 20:38:53 pgsql: round() is not portable. Use rint().