From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_dump additional options for performance |
Date: | 2008-02-26 17:25:15 |
Message-ID: | 1204046715.4252.371.camel@ebony.site |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 2008-02-26 at 11:59 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > So if I understand:
>
> > * we add switches to pg_dump to dump out separate files with --pre,
> > --post and --data (or other names) [TODO: Simon]
>
> > * we add switches to pg_restore to load/dump from the single archive
> > file the subsets of --pre, --post, --data [TODO: Magnus]
>
> Oh dear. Apparently you do not understand that *these are the same
> switches*. The way pg_dump is structured, there is only one
> implementation to be done for both cases.
Yes, agreed. I was trying to slip away from doing it so hard I didn't
notice... that code is dog-ugly and it hurts my head, so I was looking
forward to moving onto something else :-)
I'm just testing the patch now.
--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2008-02-26 17:27:13 | Re: pg_dump additional options for performance |
Previous Message | Andrew Dunstan | 2008-02-26 17:20:51 | Re: Including PL/PgSQL by default |