Re: buildenv.pl/buildenv.bat

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buildenv.pl/buildenv.bat
Date: 2007-12-08 20:11:36
Message-ID: 1197144697.21568.5.camel@mha-laptop.clients.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On Sat, 2007-12-08 at 11:34 -0500, Andrew Dunstan wrote:
>
> Magnus Hagander wrote:
> >>>> I agree with getting rid of the remaining .bat files, or at least making
> >>>> them one line wrappers for perl scripts, but I think it's too late in
> >>>> the cycle for that now. As I explained, the reason I didn't make more
> >>>> changes before was because I thought it was too late then. I did just
> >>>> enough to make running the whole thing with the buildfarm client work
> >>>> reliably.
> >>>>
> >>>>
> >>> Probably, yeah. Maybe we're better off just documenting that you need both files in some cases, rather than putting in something we don't like.
> >>>
> >>>
> >>>
> >>>
> >> Frankly, I'd rather live with more or less invisible ugliness for one
> >> release than have to document it and put the burden on users to set up
> >> two environments.
> >>
> >
> >
> > I don't really like the idea of shipping withb documentation that states you should do one thing, and it won't work... It's not invisible at all. If you follow the documentation, you can't build...
> >
> >
> >
>
> You seem to have misunderstood what I am suggesting. Of course we should
> document use of buildenv.pl in addition to the hacky fix to the .bat
> files. The hack is the part that would be invisible. The docs would be
> visible and contain what would be our ongoing practice.

Correct, I was misunderstanding it :-)

I still can't say I like that hack though. I'd rather document that you
have to do it in the .bat file for docs + gui build.

But it's better than what I thought you were proposing :-)

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2007-12-08 20:49:12 Re: Release Note Changes
Previous Message Alvaro Herrera 2007-12-08 19:48:27 Re: Release Note Changes

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-12-08 20:53:56 Re: [PATCH] automatic integer conversion
Previous Message Andrew Dunstan 2007-12-08 16:34:35 Re: buildenv.pl/buildenv.bat