Re: resetStringInfo

From: Neil Conway <neilc(at)samurai(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: resetStringInfo
Date: 2007-03-03 17:16:39
Message-ID: 1172942199.6571.49.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sat, 2007-03-03 at 11:23 -0500, Bruce Momjian wrote:
> Are there any places in our code where we could use it?

I manually grep'ed around and found a few places where resetStringInfo
can be used, but I probably didn't find them all: it's quite hard to
find all the places in which "StringInfo->len = 0" is assigned to, given
that the StringInfo might have any variable name, and variables like
"len" and "buf" are very common for other purposes.

Attached is a revised patch, I'll commit it later today.

-Neil

Attachment Content-Type Size
reset_string_info-2.patch text/x-patch 7.4 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-03-03 17:23:49 Re: Allow \pset to parse "on or off" for boolean values
Previous Message Joshua D. Drake 2007-03-03 17:09:47 Re: POSIX shared memory support