Re: AC_REPLACE_FUNCS([getaddrinfo]) in 8.1.3

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: AC_REPLACE_FUNCS([getaddrinfo]) in 8.1.3
Date: 2006-02-21 06:10:23
Message-ID: 11707.1140502223@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Albert Chin <pgsql-hackers(at)mlists(dot)thewrittenword(dot)com> writes:
> On Sun, Feb 19, 2006 at 11:32:53PM -0500, Tom Lane wrote:
>> Would you try the patch proposed at
>> http://archives.postgresql.org/pgsql-patches/2006-01/msg00299.php

> Works fine on Tru64 UNIX 4.0D and 5.1.

OK, applied to HEAD and 8.1. I'm feeling a bit of concern though after
re-reading the comment attached to the test:

# (Note: the AC_TRY_LINK probe fails on Windows, where the available
# versions of getaddrinfo don't follow normal C call protocol. This is OK
# because we want to use our own getaddrinfo.c on Windows anyway.)

It seems likely that the new coding will allow the test to *succeed* on
Windows. Does that happen, and if so is it bad? We can put in a hack
to suppress the test on Windows if necessary. Someone please check it
out on Windows ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message R, Rajesh (STSD) 2006-02-21 06:31:17 [PATCH] ipv6 support for getaddrinfo.c
Previous Message Marc G. Fournier 2006-02-21 03:26:47 Re: Updated email signature