Re: Patch: Remove gcc dependency in definition of inline functions

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On tis, 2010-01-19 at 01:29 -0800, Kurt Harriman wrote:
>> Or compiler switches could be set to disable all such warnings
>> globally. Warning 4514 is specific to inline functions; so
>> maybe it would be alright to keep it turned off globally.

> ... I think that would exactly be the right solution.

I agree that that is a better/safer approach than using __forceinline.

> Then just replace in those two locations __GNUC__ by __GNUC__ ||
> __MSVC__ (or whatever the symbol is). Or if you want to make it extra
> nice, create a symbol somewhere like in c.h that reads

> #define USE_INLINE __GNUC__ || __MSVC__

Kurt's patch proposes to try to define USE_INLINE via a configure test
rather than hard-coding it like that. While I'm not entirely convinced
that the configure test will work, I like hard-coding it even less.
Let's try the configure test and see what happens.

regards, tom lane