| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bison 2.1 on win32 |
| Date: | 2007-03-17 15:53:28 |
| Message-ID: | 11639.1174146808@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> The attached patch seems to fix the build issue. Does it seem
> acceptable/the right thing to do?
No, it seems pretty bletcherous.
> Another option would be to just reject both 2.0 and 2.1 as broken to
> build pg with, I guess...
In bison 2.3 (which is shipping with Fedora Core 6), all the uses of
__STDC__ seem to also test _MSC_VER:
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
If this fixes the problem, then I'd vote for just stating you need
bison >= 2.3 (or 2.2?) to build on MSVC.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2007-03-17 15:56:30 | Re: [PATCHES] xpath_array with namespaces support |
| Previous Message | Nikolay Samokhvalov | 2007-03-17 15:46:28 | Re: [PATCHES] xpath_array with namespaces support |