Re: fixing Makefile.shlib for solaris/gcc with -m64 flag

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Jignesh K(dot) Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM>
Cc: pgsql-hackers(at)postgresql(dot)org, Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
Subject: Re: fixing Makefile.shlib for solaris/gcc with -m64 flag
Date: 2007-01-17 16:12:53
Message-ID: 11524.1169050373@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Jignesh K. Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM> writes:
> simple if I use -m64 for 64 bit then all end binaries are generated 64-bit and the shared libraries
> are generated 32-bit and the compilation fails (ONLY ON SOLARIS) since that particular line is only
> for the condition Solaris AND gcc.

> If I use the COMPILER which is CC + CFLAGS it passes -m64 properly to it and generates shared
> libraries 64-bit and the compile continues..

Hmm ... I see we're doing it that way already for some other platforms,
but I can't help thinking it's a kluge. Wouldn't the correct answer be
that -m64 needs to be in LDFLAGS?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2007-01-17 16:23:10 Re: [COMMITTERS] pgsql: Implement width_bucket() for the
Previous Message Merlin Moncure 2007-01-17 16:03:24 Re: [PATCHES] pg_standby