| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ... |
| Date: | 2006-01-30 03:20:47 |
| Message-ID: | 1138591247.8835.6.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
On Sun, 2006-01-29 at 17:03 -0800, David Fetter wrote:
> Another followup, this time with the comment done right.
+ /* Disallow the forbidden_delimiter strings */
+ if (strcspn(cstate->delim, BADCHARS) != 1)
+ elog(ERROR, "COPY delimiter cannot be %#02x",
+ *cstate->delim);
+
The comment is still wrong: referencing "forbidden_delimiter" makes it
sound like there is something named forbidden_delimiter, but there is
not (at least in the patch as submitted).
The patch should also use ereport rather than elog, because this error
message might reasonably be encountered by the user.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kris Jurka | 2006-01-30 03:57:12 | Re: BUG #2220: PostgreSQL-JDBC 8.1-404 fails to compile with |
| Previous Message | Tom Lane | 2006-01-30 01:12:42 | Re: bug with aggregate + multi column index + index_scan |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2006-01-30 03:23:19 | Re: Want to add to contrib.... xmldbx |
| Previous Message | Michael Glaesemann | 2006-01-30 03:20:25 | Re: Want to add to contrib.... xmldbx |