Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ...

From: Neil Conway <neilc(at)samurai(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: pgsql-bugs(at)postgresql(dot)org, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ...
Date: 2006-01-30 03:20:47
Message-ID: 1138591247.8835.6.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
On Sun, 2006-01-29 at 17:03 -0800, David Fetter wrote:
> Another followup, this time with the comment done right.

+       /* Disallow the forbidden_delimiter strings */
+       if (strcspn(cstate->delim, BADCHARS) != 1)
+               elog(ERROR, "COPY delimiter cannot be %#02x",
+                        *cstate->delim);
+ 

The comment is still wrong: referencing "forbidden_delimiter" makes it
sound like there is something named forbidden_delimiter, but there is
not (at least in the patch as submitted).

The patch should also use ereport rather than elog, because this error
message might reasonably be encountered by the user.

-Neil



In response to

Responses

pgsql-bugs by date

Next:From: Kris JurkaDate: 2006-01-30 03:57:12
Subject: Re: BUG #2220: PostgreSQL-JDBC 8.1-404 fails to compile with
Previous:From: Tom LaneDate: 2006-01-30 01:12:42
Subject: Re: bug with aggregate + multi column index + index_scan

pgsql-patches by date

Next:From: Andrew DunstanDate: 2006-01-30 03:23:19
Subject: Re: Want to add to contrib.... xmldbx
Previous:From: Michael GlaesemannDate: 2006-01-30 03:20:25
Subject: Re: Want to add to contrib.... xmldbx

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group