Re: [PERFORM] A Better External Sort?

On Tue, 2005-10-04 at 16:30 +0200, Martijn van Oosterhout wrote:
> On Tue, Oct 04, 2005 at 10:06:24AM -0400, Tom Lane wrote:
> > Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > > I'm using: gcc (GCC) 3.3.5 (Debian 1:3.3.5-13)
> >
> > I don't know what the units of this number are, but it's apparently far
> > too gcc-version-dependent to consider putting into our build scripts.
> > Using gcc version 4.0.1 20050727 (current Fedora Core 4 compiler) on
> > i386, and compiling tuplesort.c as you did, I find:
> > -O2: warning goes away between 800 and 900
> > -O3: warning is always there (tried values up to 10000000)
> > (the latter behavior may indicate a bug, not sure).
>
> Facsinating. The fact that the warning goes away if you don't specify
> -finline-limit seems to indicate they've gotten smarter. Or a bug.
> We'd have to check the asm code to see if it's actually inlined or
> not.

I've been using gcc 3.4 and saw no warning when using either "-Winline"
or "-O3 -Winline".

Martijn, at the moment it sounds like this is a feature that we no
longer need to support - even if we should have done for previous
releases.

Best Regards, Simon Riggs