Re: Missing CONCURRENT VACUUM (Was: Release notes for

From: Hannu Krosing <hannu(at)skype(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: Missing CONCURRENT VACUUM (Was: Release notes for
Date: 2005-08-22 10:30:17
Message-ID: 1124706617.5236.8.camel@fuji.krosing.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On E, 2005-08-22 at 02:14 +0300, Hannu Krosing wrote:
> Probably nonInVacuumXmin needs more care, i.e. initialising and setting
> it outside GetSnapshotData, at trx start and/or end. I'm too sleepy now
> to investigate further (it's 2:10 am here).

The attached patch works now as advertized so that concurrent non-vacuum
transactions don't interfere with vacuums OldestXmin calculations.

I fixed also the "VACUUM FULL case it manages to invoke *both*
full_vacuum_rel and lazy_vacuum_rel " bug.

But I could not find the breakage (from your Aug 17 email) with

> > In my patch I specifically exclude TruncateSUBTRANS from using the
> > inVacuum flag
>
> You missed vac_truncate_clog, though.

Has somethoing changed in vac_truncate_clog or am I just too
lazy/stupid ?

--
Hannu Krosing <hannu(at)skype(dot)net>

Attachment Content-Type Size
vacuum-patch-8.1-2005.08.22-2.diff text/x-patch 15.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2005-08-22 10:32:25 Re: VACUUM/t_ctid bug (was Re: GiST concurrency commited)
Previous Message Palle Girgensohn 2005-08-22 09:40:09 Re: Win32 unicode vs ICU