From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: __cpu__ defines |
Date: | 2003-09-12 14:54:20 |
Message-ID: | 11204.1063378460@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> As part of my spinlock testing, I noticed that we test for __cpu__ when
> using gcc, and __cpu when not using gcc.
> ...
> So, I wonder if we should be testing _just_ for __cpu, perhaps starting
> in 7.5.
I might be all wet on this, but I had the idea that the __cpu__ forms
were considered more standard/common. In any case, I can't see any
good reason not to test for both. The amount of code saved by checking
only one is negligible; why should we take a chance on breaking things
for that?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-12 14:59:31 | Re: __cpu__ defines |
Previous Message | Tom Lane | 2003-09-12 14:49:32 | Re: [PATCHES] Reorganization of spinlock defines |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-12 14:59:31 | Re: __cpu__ defines |
Previous Message | Tom Lane | 2003-09-12 14:49:32 | Re: [PATCHES] Reorganization of spinlock defines |