From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: auto_explain produces invalid JSON |
Date: | 2012-02-13 16:15:10 |
Message-ID: | 11187.1329149710@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
[ sorry for ignoring this over the weekend --- I wasn't feeling very well ]
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 02/11/2012 03:22 PM, Tom Lane wrote:
>> I'm inclined to think that this is auto_explain's error, not that of
>> the core code, ie we should be changing the output.
> Well, maybe this is more to your taste, although it strikes me as more
> than something of a kludge. At least it's short :-)
I see you've already committed this, but I agree that it's quite a
kluge.
After looking a bit more at the existing explain code, it seems like the
critical issue is that explain.c has ExplainOpenGroup/ExplainCloseGroup
calls around the ExplainPrintPlan call (see ExplainOnePlan), while
auto_explain does not. I did not like your originally proposed patch
because it seemed to introduce yet another formatting concept into code
that has already got a few too many. But couldn't we fix this by
exporting ExplainOpenGroup/ExplainCloseGroup and then calling those from
auto_explain?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2012-02-13 17:13:32 | Re: Scaling XLog insertion (was Re: Moving more work outside WALInsertLock) |
Previous Message | Tom Lane | 2012-02-13 16:00:53 | Re: When do we lose column names? |