Re: Turkish downcasting in PL/pgSQL

From: ntufar <ntufar(at)pisem(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: Turkish downcasting in PL/pgSQL
Date: 2004-08-12 19:09:11
Message-ID: 1092337751.2945.16.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Greetings,

12-08-2004 Perşembe günü saat 18:32 sularında, Tom Lane dedi ki:
ntufar <ntufar(at)pisem(dot)net> writes:
> > flex (flex version 2.5.4) incorporates case-insensitivity in it's
> > state tables because if I run flex stage with LANG=C everything
> > works fine.
>
> Ick. That is of course why it worked for me when I tested it :-(
>
> > A quick and dirty fix could be implemented by placing
> > LANG=C
> > export LANG
> > in file src/pl/plpgsql/src/Makefile before calling flex.
>
> This is probably what we'd better do. Otherwise we have
> build-context-dependency in the system's behavior, which is bad.
>
I attached a diff of fix that adds LANG=C; before call to $(FLEX).
Fixes the problem here but I don't know if adding environment variable
assignment like this is appropriate. I am not too fluent in PostgreSQL
build environment and do not know where one can put a global deffinition
you are talking below.

Peter, any thoughts on this one way or the other? At the moment
> plpgsql's scan.l seems to be the only use of '%option
case-insensitive'
> but we have enough flex lexers laying about that I wouldn't be
surprised
> to have this same risk elsewhere. Is it reasonable to try to force
> LANG=C in some global fashion during the build?
>
> regards, tom lane
>
Best regards,
Nicolai Tufar

Attachment Content-Type Size
TurkishFlex.diff text/x-patch 346 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2004-08-12 19:27:29 Re: Turkish downcasting in PL/pgSQL
Previous Message Wu'kong Sun 2004-08-12 17:18:19 Re: Bug#1216

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-08-12 19:13:53 Re: [HACKERS] SAVEPOINT syntax again
Previous Message Kenneth Marshall 2004-08-12 18:25:17 Re: Re: We have got a serious problem with pg_clog/WAL synchronization