Re: pg_dump output portability

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump output portability
Date: 2002-08-15 20:13:00
Message-ID: 1067.1029442380@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane writes:
>> Switching the default is definitely fine with me, but I'd lean towards
>> ripping it out entirely, given that the backend-supplied chunks of stuff
>> are not going to have extra quotes. We always tell people "always quote
>> or never quote" a given identifier; pg_dump scripts ought to follow that
>> rule.

> It occurred to me that pg_dump would need to know which names are
> keywords. Ugh.

Good point, but not insurmountable. We could easily make pg_dump
include the backend's src/backend/parser/keywords.o file and then
use that subroutine to test for keyword-ness. This would be a 100%
solution when dumping from a server of the same version, and about
a 99.9% solution when dumping from an older server.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-08-15 20:36:31 Re: Standard replication interface?
Previous Message Vince Vielhaber 2002-08-15 20:04:24 Re: Open 7.3 items