Re: database file compatibility patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: database file compatibility patch
Date: 2005-10-03 02:11:39
Message-ID: 10395.1128305499@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>> There's not much need to check endianness explicitly, since the
>> pg_control_version check will surely fail if there's an endianness
>> discrepancy (not to mention the other checks on pg_control fields).

> Oh, right. So for the same reason, is it safe to remove the endian check
> in FsmCacheFileHeader?

[ Scratches head... ] Yeah, I would think so. I'm trying to remember
why I put that code in there in the first place ...

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Qingqing Zhou 2005-10-03 04:37:38 cleanup log_disconnections()
Previous Message Qingqing Zhou 2005-10-03 02:05:42 Re: database file compatibility patch