| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql source suggestions |
| Date: | 2003-02-13 04:38:11 |
| Message-ID: | 10392.1045111091@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Jeroen T. Vermeulen" <jtv(at)xs4all(dot)nl> writes:
> I've been playing around with the source for psql, and as a result I
> did some cleaning up in common.c. Would anyone be interested in seeing
> patches for that? The main benefit is some eliminated code duplication,
> plus the removal of some warts like 'continue' and 'break' where they
> weren't needed.
Sure, send it along to pgsql-patches. Code beautification is a
worthwhile goal that we spend far too little time on.
Of course, beauty is in the eye of the beholder, so there may not be
universal agreement that you made improvements ;-). But send 'em along
and then we can debate the point.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-02-13 04:46:11 | Re: log_duration |
| Previous Message | Curt Sampson | 2003-02-13 04:32:15 | Re: Changing the default configuration (was Re: |