| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Dennis Vshivkov <walrus(at)amur(dot)ru>, 333854(at)bugs(dot)debian(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] Bug#333854: pg_group file update problems |
| Date: | 2005-10-14 15:55:32 |
| Message-ID: | 10374.1129305332@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> In the patch, notice the old comment that suggests we might need to use
> CommandCounterIncrement().
... which you failed to fix in any meaningful way. I'd suggest
/*
* Advance the commmand counter to ensure we see all results
* of current transaction.
*/
CommandCounterIncrement();
and then change SnapshotSelf to SnapshotNow, since there's no longer any
reason for it to be special. Compare to CVS tip which already does it
that way. See also the identical code in write_user_file (which perhaps
has no bug, but ISTM it should stay identical).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | han.holl | 2005-10-14 16:44:54 | Re: Postgres logs to syslog LOCAL0 |
| Previous Message | Bruce Momjian | 2005-10-14 15:44:32 | Re: [BUGS] Bug#333854: pg_group file update problems |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-10-14 17:37:56 | Re: [BUGS] Bug#333854: pg_group file update problems |
| Previous Message | Bruce Momjian | 2005-10-14 15:44:32 | Re: [BUGS] Bug#333854: pg_group file update problems |