| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Bad bug in fopen() wrapper code |
| Date: | 2006-10-02 14:33:18 |
| Message-ID: | 10370.1159799598@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> I agree that this code is both wrong and unreadable (although in
>> practice the _setmode will probably never fail, which is why our
>> attention hasn't been drawn to it). Is someone going to submit a
>> patch? I'm hesitant to change the code myself since I'm not in a
>> position to test it.
> I can look at fixing that. Is it something we want to do for 8.2, or
> wait until 8.3? If there's a hidden bug, I guess 8.2?
Yeah, I think it's 8.2 material.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2006-10-02 14:38:47 | Re: In which module does query rewriting takes place |
| Previous Message | Shaunak Godbole | 2006-10-02 14:30:59 | In which module does query rewriting takes place |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Strong, David | 2006-10-02 16:06:35 | Re: Faster StrNCpy |
| Previous Message | Magnus Hagander | 2006-10-02 12:19:08 | Re: [HACKERS] Bad bug in fopen() wrapper code |