Re: commands subdirectory continued -code cleanup

From: John Gray <jgray(at)azuli(dot)co(dot)uk>
To: Fernando Nasser <fnasser(at)redhat(dot)com>
Cc: Hackers List <pgsql-hackers(at)postgresql(dot)org>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Subject: Re: commands subdirectory continued -code cleanup
Date: 2002-04-20 10:16:16
Message-ID: 1019297779.23213.6.camel@adzuki
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2002-04-19 at 20:38, Fernando Nasser wrote:
> John Gray wrote:
> >
> > and two macros:
> >
> > RECURSE_OVER_CHILDREN(relid);
> > AlterTableDoSomething(childrel,...);
> > RECURSE_OVER_CHILDREN_END;
> >
> > (this seems more straightforward than passing the text of the function
> > call as a macro parameter).
> >
>
> Suggestion:
>
> RECURSE_OVER_CHILDREN(inh, relid)
> {
> AlterTableDoSomething(childrel,...);
> }
>

Yes, that would be nicer -I just have to work out a suitable rewrite of
the code so that it could fit that kind of macro setup -at present,
there is code that is executed in each iteration of the loop, which
means there is more than one group to close after the AlterTable call.

I'll think on it...

Regards

John
--
John Gray ECHOES: sponsored walks for Christian Aid to the highest
Azuli IT points of English counties, 4th-6th May 2002
www.azuli.co.uk www.stannesmoseley.care4free.net/echoes.html

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sander Steffann 2002-04-20 11:47:27 Re: Schema (namespace) privilege details
Previous Message John Gray 2002-04-20 09:14:16 Re: commands subdirectory continued -code cleanup