Re: PATCH: CITEXT 2.0 v3

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: CITEXT 2.0 v3
Date: 2008-07-14 06:37:36
Message-ID: 06A41272-86BF-43D0-A21C-7B514EB73E74@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jul 13, 2008, at 10:19, Tom Lane wrote:

>>> You might try running the
>>> opr_sanity regression test on this module to see if it finds any
>>> other silliness. (Procedure: insert the citext definition script
>>> into the serial_schedule list just ahead of opr_sanity, run tests,
>>> make sure you understand the reason for any diffs in the opr_sanity
>>> result. There will be at least one from the uses of text-related
>>> functions for citext.)
>
>> Thanks. Added to my list.
>
> BTW, actually a better idea would be to put citext.sql at the front of
> the list and just run the whole main regression series with it
> present.
> typ_sanity and oidjoins might possibly find issues too.

Um, stupid question (sorry, I'm not familiar with how the regression
tests are organized): serial_schedule doesn't look like a file into
which I can insert an SQL file. How would I do that?

Thanks,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2008-07-14 06:39:44 Re: PATCH: CITEXT 2.0 v3
Previous Message Tom Lane 2008-07-14 05:06:43 Re: gsoc, text search selectivity and dllist enhancments