Re: Really annoying comments...

From: "Rod Taylor" <rbt(at)zort(dot)ca>
To: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Hackers List" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Really annoying comments...
Date: 2002-04-21 20:09:45
Message-ID: 065801c1e970$7bc08cb0$8001a8c0@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This makes the most sense. One could assume a user who doesn't have
access to a particular database shouldn't know what it's for either.
So making the comments global could be problematic in some cases.

I'll enforce this and send in a patch.
--
Rod
----- Original Message -----
From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Rod Taylor" <rbt(at)zort(dot)ca>; "Hackers List"
<pgsql-hackers(at)postgresql(dot)org>
Sent: Sunday, April 21, 2002 2:49 PM
Subject: RE: [HACKERS] Really annoying comments...

>
>
> > -----Original Message-----
> > From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> > Sent: 21 April 2002 19:45
> > To: Dave Page
> > Cc: Rod Taylor; Hackers List
> > Subject: Re: [HACKERS] Really annoying comments...
> >
> >
> > Dave Page <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > >> I'm more inclined to rip it out ;-).
> >
> > > Eeep! pgAdmin handles comments coming from multiple
pg_description
> > > tables and it works very well (IMHO) in the pgAdmin UI. By
> > all means
> > > make them work more sensibly in whatever way seems most
> > appropriate -
> > > I'll fix pgAdmin to handle it, but don't just rip them out
please!!
> >
> > Well, it would seem like the only sensible rule would be to
> > allow COMMENT ON DATABASE only for the *current* database.
> > Then at least you know which DB to look in.
>
> That wouldn't cause me any pain - in pgAdmin the comment is just a
property
> of a pgDatabase object - if you modify it, it will always be set
through a
> connection to that database.
>
> Regards, Dave.
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Lockhart 2002-04-21 20:27:15 Re: Patches applied; initdb time!
Previous Message Thomas Lockhart 2002-04-21 20:02:13 Patches applied; initdb time!