Re: encoding names

From: "Serguei Mokhov" <sa_mokho(at)alcor(dot)concordia(dot)ca>
To: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Karel Zak" <zakkr(at)zf(dot)jcu(dot)cz>
Cc: "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: encoding names
Date: 2001-08-18 03:02:06
Message-ID: 045601c12792$2b754a20$5dd9fea9@gunn
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


----- Original Message -----
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
Sent: Friday, August 17, 2001 12:11 PM

> Karel Zak writes:
>
> > - possible is use synonyms for encoding (an example ISO-8859-1,
> > Latin1, l1)
>
> On the choice of synonyms: Do we really want to add that many synonyms
> that are not the standard name? I think the following are not necessary:
>
> cyrillic, cp819, ibm819, isoir100x, l1-4

I'm not sure about others, but 'cyrillic' is a quite ambigous alias,
because it can denote many slavic languages: Russian, Ukranian,
Bulgarian, Serbian are few examples, so I believe it should be excluded
from the list of synomyms.

> KOI8 needs to be aliased as koi8r.

... and Karel can you change these so they are consistent with
others:

> KOI8_to_utf(unsigned char *iso, unsigned char *utf, int len)
> {
> local_to_utf(iso, utf, LUmapKOI8, sizeof(LUmapKOI8) / sizeof(pg_local_to_utf), PG_KOI8, len);
> }

to

koi8r_to_utf(unsigned char *iso, unsigned char *utf, int len)
^^^^^
{
local_to_utf(iso, utf, LUmapKOI8R, sizeof(LUmapKOI8R) / sizeof(pg_local_to_utf), PG_KOI8R, len);
} ^^^^^ ^^^^^ ^^^^^

> WIN_to_utf(unsigned char *iso, unsigned char *utf, int len)
> {
> local_to_utf(iso, utf, LUmapWIN, sizeof(LUmapWIN) / sizeof(pg_local_to_utf), PG_WIN1251, len);
> }

to

win1251_to_utf(unsigned char *iso, unsigned char *utf, int len)
^^^^^^^
{
local_to_utf(iso, utf, LUmapWIN1251, sizeof(LUmapWIN1251) / sizeof(pg_local_to_utf), PG_WIN1251, len);
^^^^^^^ ^^^^^^^ ^^^^^^^
}

S.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Moscatt 2001-08-18 06:45:35 Setting Up User Accounts For PostgreSQL ?
Previous Message Peter Moscatt 2001-08-18 02:10:46 Re: CREATEDB Where ??

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-18 04:08:08 Re: Patch: use SCM_CREDS authentication over PF_LOCAL sockets
Previous Message Serguei Mokhov 2001-08-18 02:59:18 Re: Added \n to libpq prints