Re: where's the build environment for odbc

Hi Jon,

I have run your patch past a developer who is familiar with the psqlODBC
and PostgreSQL build systems (something which I am not). He made some
comments based on which I will not be applying your patch to CVS as it
currently stands:

The changes to AC_INIT and AM_INIT_AUTOMAKE change from "new style" to
"old style" and are therefore definitely wrong.

The PGAC_ARG_* macros provide a more robust argument checking than the
standard ones, so I would keep them. If there is a problem that you
need to get these macros from the PostgreSQL source tree (only for CVS
developers, not "to build"), then just copy over the required m4 files
and put them in your CVS.

The changes in AM_CONDITIONAL are then pointless if you keep using the
PGAC_ARG_ macros. Also, "$with_unixodbc-no" is wrong.

Replacing PGAC_VAR_INT_TIMEZONE by AC_STRUCT_TIMEZONE is wrong, because
they don't do the same thing at all. Again, just copy the m4 file if
you must.

If you have time to submit a revised patch based on these comments, it
would be appreciated.

Regards, Dave.

> -----Original Message-----
> From: Jon Willeke [mailto:willeke(at)users(dot)sourceforge(dot)net]
> Sent: 02 February 2004 16:53
> To: odbc list
> Subject: Re: [ODBC] where's the build environment for odbc
>
> No, I did not build in a PostgreSQL source tree. I have the
> postgresql packages, as shipped in SuSE Linux 8.2.
>
> I used autoconf 2.57, automake 1.7.6, and libtool 1.4.3. I
> did not pass the -I $PGSRC/config switch to aclocal, because
> I have no such file. Otherwise, I followed the README.
>
> The resulting driver seems to work fine.
>
> At 1/31/2004, Dave Page wrote:
>
> >Looking back at your previous message, I see that you use the same
> >version of autoconf (2.5.7) as I use to build the
> distribution tarballs.
> >
> >Did you follow the instructions in README.unix and perform the build
> >from within a PostgreSQL source tree?
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to
> majordomo(at)postgresql(dot)org)
>