RE: [PROPOSAL]a new data type 'bytea' for ECPG

From: "Matsumura, Ryo" <matsumura(dot)ryo(at)jp(dot)fujitsu(dot)com>
To: 'Michael Meskes' <meskes(at)postgresql(dot)org>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PROPOSAL]a new data type 'bytea' for ECPG
Date: 2018-12-07 10:54:49
Message-ID: 03040DFF97E6E54E88D3BFEE5F5480F737A6BA0D@G01JPEXMBYT04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Meskes-san

Tnak you for your comment.

> I do think, though, we should change the debug output for
> ecpg_free_params().

I try to change about it. Next patch will print binary in hex-format.

> > > The patch does not support ECPG.bytea in sqltype of "struct
> > > sqlvar_struct"
> > > because of compatibility.
>
> Sorry I do not really understand what you mean. Could you please
> explain?

I meaned that existing applications that receive data of bytea column
with using sqlda will encounter their unknown type(=ECPG.bytea) in
sqlvar_struct.sqltype.

Regards
Ryo Matsumura

> -----Original Message-----
> From: Michael Meskes [mailto:meskes(at)postgresql(dot)org]
> Sent: Wednesday, December 5, 2018 8:24 PM
> To: Matsumura, Ryo/松村 量 <matsumura(dot)ryo(at)jp(dot)fujitsu(dot)com>; Tsunakawa,
> Takayuki/綱川 貴之 <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
> Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
> Subject: Re: [PROPOSAL]a new data type 'bytea' for ECPG
>
> Matsumura-san,
>
> > Sorry to bother you, but I hope any comment of yours.
>
> It is no bother.
>
> I'm fine with the patch if it does not work against the standard.
>
> I do think, though, we should change the debug output for
> ecpg_free_params(). The way it is now it prints binary values which we
> also have in our test suite. I'm afraid this will come back to haunt
> us.
>
> > > The patch does not support ECPG.bytea in sqltype of "struct
> > > sqlvar_struct"
> > > because of compatibility.
>
> Sorry I do not really understand what you mean. Could you please
> explain?
>
> Michael
> --
> Michael Meskes
> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
> Meskes at (Debian|Postgresql) dot Org
> Jabber: michael at xmpp dot meskes dot org
> VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2018-12-07 11:14:14 Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0
Previous Message PG Bug reporting form 2018-12-07 10:42:54 BUG #15541: Use after release in PQprint