| From: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "'Michael Paquier'" <michael(dot)paquier(at)gmail(dot)com>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Regarding BGworkers |
| Date: | 2013-08-02 04:35:36 |
| Message-ID: | 007c01ce8f39$bc4cf130$34e6d390$@kapila@huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, August 02, 2013 4:19 AM Michael Paquier wrote:
On Fri, Aug 2, 2013 at 1:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
On Sun, Jul 28, 2013 at 1:26 AM, Amit kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
>>> 2. Shouldn't function
>>> do_start_bgworker()/StartOneBackgroundWorker(void) be moved to
bgworker.c
>>> as similar functions AutoVacWorkerMain()/PgArchiverMain() are in
their respective files.
>> Yes, perhaps so. Other votes?
> StartOneBackgroundWorker uses StartWorkerNeeded and HaveCrashedWorker, and
IMO, we should not expose that outside the postmaster.
How about exposing Set/Get for these from bgworker?
> On the contrary,
> moving do_start_bgworker would be fine, as it uses nothing exclusive to
the postmaster as far as I saw, and it would also make it more consistent
with > the other features.
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-08-02 04:40:16 | Re: Regarding BGworkers |
| Previous Message | Bruce Momjian | 2013-08-02 04:20:15 | No more need for pg_clearxlogtail? |